Skip to content

Add Totalconnect config flow#32126

Merged
bdraco merged 111 commits intohome-assistant:devfrom
austinmroczek:totalconnect-config-flow
Apr 13, 2020
Merged

Add Totalconnect config flow#32126
bdraco merged 111 commits intohome-assistant:devfrom
austinmroczek:totalconnect-config-flow

Conversation

@austinmroczek
Copy link
Copy Markdown
Contributor

@austinmroczek austinmroczek commented Feb 23, 2020

Proposed change

Adds a config flow for totalconnect so users can enter config via the user interface. Adds tests for it as well.

Bumps total-connect-client from 0.50 to 0.52.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
# YAML configuration is no longer required..but if you want to
totalconnect:
  username: !secret totalconnect_username
  password: !secret totalconnect_password

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [n/a] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

Working toward this...maybe next PR

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

it is a burglar or fire or carbon monoxide so automations can take
appropriate actions.  Updated TotalConnect component to handle these new
states.
Also bumps total_connect_client to 0.27.
Comment thread homeassistant/components/totalconnect/__init__.py Outdated
Comment thread homeassistant/components/totalconnect/__init__.py Outdated
Comment thread homeassistant/components/totalconnect/config_flow.py Outdated
Comment thread tests/components/totalconnect/test_config_flow.py Outdated
Comment thread tests/components/totalconnect/test_config_flow.py Outdated
Comment thread tests/components/totalconnect/test_config_flow.py Outdated
Comment thread tests/components/totalconnect/test_config_flow.py Outdated
Comment thread tests/components/totalconnect/test_config_flow.py Outdated
@MartinHjelmare
Copy link
Copy Markdown
Member

Please rebase on latest dev branch to let the build pass.

Comment thread homeassistant/components/totalconnect/__init__.py
@MartinHjelmare
Copy link
Copy Markdown
Member

This is not a breaking change, correct?

@austinmroczek
Copy link
Copy Markdown
Contributor Author

This is not a breaking change.

@austinmroczek
Copy link
Copy Markdown
Contributor Author

I'm getting a pylint error for unused import on config_flow.py. Even after inserting # pylint: disable=unused-import at the end of the line, I still get the error. Any suggestions?

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Mar 11, 2020

That's a know pylint bug. Please disable that error locally at line 10.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@austinmroczek
Copy link
Copy Markdown
Contributor Author

Anything left to do before this is merged?

@MartinHjelmare
Copy link
Copy Markdown
Member

We should wait with merging this until we know how to best solve the linked issue with regards to pulling the fix into a release.

@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes.

@bdraco bdraco merged commit c7ab5de into home-assistant:dev Apr 13, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
@austinmroczek austinmroczek deleted the totalconnect-config-flow branch April 26, 2020 21:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants