Add Totalconnect config flow#32126
Merged
bdraco merged 111 commits intohome-assistant:devfrom Apr 13, 2020
Merged
Conversation
update to latest HA
it is a burglar or fire or carbon monoxide so automations can take appropriate actions. Updated TotalConnect component to handle these new states.
Also bumps total_connect_client to 0.27.
…. Bump total_connect_client to 0.28.
pull in latest
MartinHjelmare
requested changes
Mar 9, 2020
Member
|
Please rebase on latest dev branch to let the build pass. |
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
…roczek/home-assistant into totalconnect-config-flow
Member
|
This is not a breaking change, correct? |
Contributor
Author
|
This is not a breaking change. |
Contributor
Author
|
I'm getting a pylint error for unused import on config_flow.py. Even after inserting |
Member
|
That's a know pylint bug. Please disable that error locally at line 10. |
Contributor
Author
|
Anything left to do before this is merged? |
Member
|
We should wait with merging this until we know how to best solve the linked issue with regards to pulling the fix into a release. |
18 tasks
MartinHjelmare
approved these changes
Mar 28, 2020
Member
|
Can be merged when build passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds a config flow for totalconnect so users can enter config via the user interface. Adds tests for it as well.
Bumps total-connect-client from 0.50 to 0.52.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
Update TotalConnect for config flow home-assistant.io#12171
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
Working toward this...maybe next PR